Skip to content

Convert benchmarks to ruff format #18068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 13, 2025
Merged

Convert benchmarks to ruff format #18068

merged 4 commits into from
May 13, 2025

Conversation

@hmellor
Copy link
Member

@hmellor hmellor commented May 13, 2025 •
edited by github-actions bot
Loading

If we are converting directory x:

  • In x, we add a local pyproject.toml which:
    • overrides ruff's line length to 88 (it's own default)
    • removes the deprecated type ignores
    • enables isort in ruff
    • enables formatting of code in docstrings (good for the API docs)
  • We add x to the list of files to run ruff-format on in .pre-commit-config.yaml
  • We add x to the list of ignores in the yapf and isort config in the root pyproject.toml

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@hmellor hmellor mentioned this pull request May 13, 2025
Closed
5 tasks
@mergify mergify bot added the ci/build label May 13, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 13, 2025 11:41
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 13, 2025
@DarkLight1337 DarkLight1337 merged commit 009d9e7 into vllm-project:main May 13, 2025
38 of 40 checks passed
@hmellor hmellor deleted the ruff-format-benchmarks branch May 13, 2025 13:49
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@hmellor
Convert benchmarks to ruff format (vllm-project#18068)
8a93a67 
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees

No one assigned

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed structured-output

Projects

Structured Output
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hmellor @DarkLight1337